Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebar3 support #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add rebar3 support #2

wants to merge 1 commit into from

Conversation

leostera
Copy link

@leostera leostera commented Apr 23, 2019

Hello! opened this as a first stab and to get the ball rolling.

It currently seems to work fine, if I point at it using

{deps, [ {rebar, {git, "https://github.com/ostera/lagra", {ref, "master"}}} ]}.

Let me know if everything still works on your end :)

@darkling
Copy link
Owner

Looks reasonable, and works for compiling, as far as I can tell. I haven't tried actually running anything from the rebar3-built version yet. :)

Three points, I think:

  • does the rebar.lock file have to be committed? It looks to me like it should be in .gitignore instead.
  • rebar3 ct doesn't work -- probably because I've put the ct tests in ./ct, not in ./test. I think it needs some configuration in the test profile in rebar.config. Can you sort that out?
  • The ./src/lagra.app.src file is incorrect (it's got the wrong version, for a start), and doesn't play well with erlang.mk -- if you could respin this patch without that file in, I'll commit the ./ebin/lagra.app file which erlang.mk builds. I've checked with Tristan, and he says that should be sufficient to make everything work smoothly.

Oh, and building the edoc is broken, but I think that's expected behaviour right now, because building it with erlang.mk is broken in the exact same way (oops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants