Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory usage of grill, related to captcha #479

Closed
wants to merge 5 commits into from

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Nov 30, 2023

What I did:

  • Move captcha so its now only rendered once everytime, instead of having multiple recaptcha instances for every CaptchaInvisible component displayed
  • Remove unused fields from the posts data (from datahub & squid)
    Note: this change has a bit of drawback, which is if the original post content has tags or other removed fields, it won't be included in the updated post after updating the content, because the UI doesn't get that fields

@teodorus-nathaniel
Copy link
Contributor Author

After checking result:

  1. Multiple recaptcha instance doesn't seem to increase the memory usage
  2. Reducing some fields in the posts doesn't decrease the memory usage significantly, if checked from network tab, 50 posts is 1mb so, reducing some fields won't decrease it much

Current:
image
After:
image

The number fluctuates but mostly its similar

@teodorus-nathaniel teodorus-nathaniel deleted the deploy/memory branch March 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant