Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-2736: propagate Allow-unstable-test to CI_ALLOW_UNSTABLE_TEST #455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SRE-2736: propagate Allow-unstable-test to CI_ALLOW_UNSTABLE_TEST #455

wants to merge 1 commit into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 14, 2025

Propagate the value of the Allow-unstable-test commit pragma to the CI_ALLOW_UNSTABLE_TEST parameter of package downstream build.

@grom72 grom72 marked this pull request as draft January 14, 2025 14:31
@grom72
SRE-2736 test: propagate Allow-unstable-test to CI_ALLOW_UNSTABLE_TEST
b8b3a2e 
Propagate the value of Allow-unstable-test commit pragma to
CI_ALLOW_UNSTABLE_TEST parameter of package downstream build.

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Copy link
Contributor Author

grom72 commented Jan 14, 2025

Tested with daos-stack/pmdk#43 (https://github.com/daos-stack/pmdk/compare/grom72/DAOS-16660-no-error-msg-on-user-abort):

@Library(value="pipeline-lib@grom72/SRE-2736") _
packageBuildingPipelineDAOSTest(['distros': ['el8', 'el9', 'leap15', 'ubuntu20.04'],
				 'test-tag': 'pr daosio'])

daos-stack/pmdk@4dda74d:

Allow-unstable-test: true

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-pmdk-PR-43-master/36/parameters/
image

@grom72 grom72 marked this pull request as ready for review January 14, 2025 15:06
daosbuild3
daosbuild3 previously approved these changes Jan 14, 2025
View reviewed changes
@JohnMalmberg JohnMalmberg dismissed daosbuild3’s stale review January 14, 2025 15:39

Robots should not be doing approvals

@grom72
Copy link
Contributor Author

grom72 commented Jan 16, 2025 •
edited
Loading

All tests pass:
https://build.hpdd.intel.com/job/daos-stack/job/pipeline-lib/job/PR-455/2/pipeline-graph/
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-455-release-2.6/4/
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-pipeline-lib-PR-455-release-2.6/10/pipeline-console/

@grom72 grom72 requested a review from a team January 16, 2025 07:18
phender
phender approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comment. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@JohnMalmberg JohnMalmberg JohnMalmberg approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@daosbuild3 daosbuild3 daosbuild3 left review comments

@janekmi janekmi Awaiting requested review from janekmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grom72 @daltonbohning @JohnMalmberg @daosbuild3 @phender