Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endeavour: clean up scripts #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

endeavour: clean up scripts #145

wants to merge 1 commit into from

Conversation

jamesanunez
Copy link
Contributor

The following modifications were made to the Endeavour scripts:

  1. In run_client.sh, we export the TB variable when calling
    mount_defuse.sh. mount_dfuse.sh doesn't use the TB variable.
    Thus, we can remove the export of the TB variable when calling
    mount_defuse.sh.
  2. Both clean_agents.sh and start_agent.sh source client_env.sh.
    The script run_client.sh sources client_env.sh in the clush
    calls to clean_agents.sh and start_agent.sh. We don't need to
    source client_env.sh in the clush call.
  3. In run_client.sh, we call “ls -al /panfs/users/${USER}/apps/${MPI}/lammps”
    no matter what application is being executed. We can remove this
    call to 'ls'.
  4. The script start_agent.sh removes and then creates the DAOS mount
    point. Removing and creating the mount point doesn't have anything
    to do with starting the agent and should be removed. The run_clientsh
    script removes and creates the DAOS mount point.
  5. We can remove the duplicate calls to adding FUSE to the PATH
    and LD_LIBRARY_PATH variables.

Signed-off-by: James Nunez [email protected]

The following modifications were made to the Endeavour scripts:

1. In run_client.sh, we export the TB variable when calling
   mount_defuse.sh. mount_dfuse.sh doesn't use the TB variable.
   Thus, we can remove the export of the TB variable when calling
   mount_defuse.sh.
2. Both clean_agents.sh and start_agent.sh source client_env.sh.
   The script run_client.sh sources client_env.sh in the clush
   calls to clean_agents.sh and start_agent.sh. We don't need to
   source client_env.sh in the clush call.
3. In run_client.sh, we call “ls -al /panfs/users/${USER}/apps/${MPI}/lammps”
   no matter what application is being executed. We can remove this
   call to 'ls'.
4. The script start_agent.sh removes and then creates the DAOS mount
   point. Removing and creating the mount point doesn't have anything
   to do with starting the agent and should be removed. The run_clientsh
   script removes and creates the DAOS mount point.
5. We can remove the duplicate calls to adding FUSE to the PATH
   and LD_LIBRARY_PATH variables.

Signed-off-by: James Nunez <[email protected]>
@jamesanunez jamesanunez requested a review from rpadma2 July 29, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant