Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16362 pydaos: increase torch ftest timeout #15829

Merged
merged 1 commit into from
Feb 5, 2025
Merged

DAOS-16362 pydaos: increase torch ftest timeout #15829

merged 1 commit into from
Feb 5, 2025

Conversation

enakta
Copy link
Contributor

@enakta enakta commented Feb 3, 2025

To be on the safe side.

Features: PytorchDatasetsTest,PytorchCheckpointTest

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@enakta enakta requested review from a team as code owners February 3, 2025 03:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

Ticket title is 'pytorch checkpoint module'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16362

@enakta enakta requested a review from daltonbohning February 3, 2025 03:14
@enakta enakta changed the title DAOS-16362: pydaos: increase torch ftest timeout DAOS-16362 pydaos: increase torch ftest timeout Feb 3, 2025
@0xE0F
DAOS-16362 pydaos: increase torch ftests timeout
a64bdd0 
To be on the safe side.

Features: PytorchDatasetsTest,PytorchCheckpointTest

Signed-off-by: Denis Barakhtanov <[email protected]>
@0xE0F 0xE0F force-pushed the 0xe0f/pydaos.torch.bump-ftest-timeout branch from 07549c1 to a64bdd0 Compare February 3, 2025 03:17
@enakta enakta mentioned this pull request Feb 3, 2025
Merged
18 tasks
@enakta enakta requested a review from johannlombardi February 3, 2025 03:18
@enakta enakta requested a review from mjmac February 3, 2025 22:18
@daltonbohning
Copy link
Contributor

This will not run the remaining CI stages since only the one test was modified. I added gatekeeper but FYI landing is closed currently.

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 4, 2025
@daltonbohning daltonbohning requested a review from a team February 4, 2025 21:37
@jolivier23 jolivier23 merged commit caf5475 into master Feb 5, 2025
54 checks passed
@jolivier23 jolivier23 deleted the 0xe0f/pydaos.torch.bump-ftest-timeout branch February 5, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmac mjmac mjmac approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enakta @daltonbohning @mjmac @jolivier23 @0xE0F