Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Failed Tests #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Addressing Failed Tests #15

wants to merge 2 commits into from

Conversation

jclemons555
Copy link 

1. Test 10: instrument/instrument/factories/ARCSBootstrap_TestCase
    ◦ Cause: Incorrect use of the sort() method.
    ◦ Solution: Change records.sort(lambda x, y: x[0] - y[0]) to records.sort(key=lambda x: x[0]).
2. Test 20 & 21: instrument/instrument/geometry/yaml/parser_TestCase & renderer_TestCase
    ◦ Cause: Missing Loader argument in yaml.load() function.
    ◦ Solution: Update to use yaml.load(open(path)) for Python 3 compatibility.

@jclemons555
Update ARCSDetPackCSVParser.py
47d918a 
        ◦ Cause: Incorrect use of the sort() method.
        ◦ Solution: Change records.sort(lambda x, y: x[0] - y[0]) to records.sort(key=lambda x: x[0]).
@jclemons555
Update __init__.py
f5cba65 
        ◦ Cause: Missing Loader argument in yaml.load() function.
        ◦ Solution: Update to use d = yaml.load(open(path), Loader=yaml.Loader) for Python 3 compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jclemons555