Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termdesc: foot has octants since 1.20.0 #2846

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

dnkl
Copy link
Contributor

@dnkl dnkl commented Jan 16, 2025

References:

I realize this will create a merge conflict with #2845, sorry about that, be happy to rebase either PR myself :)

@dankamongmen
Copy link
Owner

rebase and i'll merge! how exciting!

@dnkl dnkl force-pushed the foot-has-octants branch from 2465118 to 845b3de Compare January 17, 2025 05:06
@dnkl
Copy link
Contributor Author

dnkl commented Jan 17, 2025

Rebased

@dankamongmen dankamongmen merged commit c11efe8 into dankamongmen:master Jan 17, 2025
3 checks passed
@dankamongmen
Copy link
Owner

alright, we now have an octants-enabled emulator! the keller demo ought render images in octants for you.

@dnkl dnkl deleted the foot-has-octants branch January 17, 2025 06:33
@dnkl
Copy link
Contributor Author

dnkl commented Jan 17, 2025

It does, but only if I comment out

notcurses/src/lib/termdesc.c

Lines 1060 to 1062 in c11efe8

if(wcwidth(L'𜴀') < 0){
ti->caps.octants = false;
}
(I believe glibc has been updated to Unicode 16, but it's still only on the master branch, not released).

Btw, good to see you back!

@dankamongmen
Copy link
Owner

notcurses/src/lib/termdesc.c

Lines 1060 to 1062 in c11efe8

if(wcwidth(L'𜴀') < 0){
ti->caps.octants = false;
}

(I believe glibc has been updated to Unicode 16, but it's still only on the master branch, not released).

oh yeah, forgot about this, doh

Btw, good to see you back!

=] thanks! it's good to be back! i just woke up one day about a year and a half ago and said, "i do not care to think about terminal graphics at the moment." then about a week ago, i woke up and was like, "it is time." all energy flows according to the whims of Eris.

@dnkl
Copy link
Contributor Author

dnkl commented Jan 17, 2025

That's the nice thing about programming-as-a-hobby; take a break anytime you want/need to. Personal life changes (good ones) means I'm working considerably less on foot for the time being, but I'm sure that'll change before long :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants