Skip to content

Commit

Permalink
iommu: Remove iommu_group_get_by_id()
Browse files Browse the repository at this point in the history
This is never called.

Signed-off-by: Jason Gunthorpe <[email protected]>
Reviewed-by: Robin Murphy <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>
  • Loading branch information
jgunthorpe authored and joergroedel committed Apr 14, 2023
1 parent e223864 commit f7f9c05
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 35 deletions.
29 changes: 0 additions & 29 deletions drivers/iommu/iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -882,35 +882,6 @@ struct iommu_group *iommu_group_alloc(void)
}
EXPORT_SYMBOL_GPL(iommu_group_alloc);

struct iommu_group *iommu_group_get_by_id(int id)
{
struct kobject *group_kobj;
struct iommu_group *group;
const char *name;

if (!iommu_group_kset)
return NULL;

name = kasprintf(GFP_KERNEL, "%d", id);
if (!name)
return NULL;

group_kobj = kset_find_obj(iommu_group_kset, name);
kfree(name);

if (!group_kobj)
return NULL;

group = container_of(group_kobj, struct iommu_group, kobj);
BUG_ON(group->id != id);

kobject_get(group->devices_kobj);
kobject_put(&group->kobj);

return group;
}
EXPORT_SYMBOL_GPL(iommu_group_get_by_id);

/**
* iommu_group_get_iommudata - retrieve iommu_data registered for a group
* @group: the group
Expand Down
6 changes: 0 additions & 6 deletions include/linux/iommu.h
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ extern bool iommu_present(struct bus_type *bus);
extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
extern struct iommu_domain *iommu_domain_alloc(struct bus_type *bus);
extern struct iommu_group *iommu_group_get_by_id(int id);
extern void iommu_domain_free(struct iommu_domain *domain);
extern int iommu_attach_device(struct iommu_domain *domain,
struct device *dev);
Expand Down Expand Up @@ -746,11 +745,6 @@ static inline struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
return NULL;
}

static inline struct iommu_group *iommu_group_get_by_id(int id)
{
return NULL;
}

static inline void iommu_domain_free(struct iommu_domain *domain)
{
}
Expand Down

0 comments on commit f7f9c05

Please sign in to comment.