memory tier: release the new_memtier in find_create_memory_tier()

In find_create_memory_tier(), if failed to register device, then we should release new_memtier from the tier list and put device instead of memtier. Link: https://lkml.kernel.org/r/[email protected] Fixes: 9832fb8 ("mm/demotion: expose memory tier details via sysfs") Signed-off-by: Tong Tiangen <[email protected]> Cc: Aneesh Kumar K.V <[email protected]> Cc: Hanjun Guo <[email protected]> Cc: Kefeng Wang <[email protected]> Cc: Guohanjun <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
daniel-0723 · Feb 10, 2023 · 9341913 · 9341913
1 parent 8f17feb
commit 9341913
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
@@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty
 
 	ret = device_register(&new_memtier->dev);
 	if (ret) {
-		list_del(&memtier->list);
-		put_device(&memtier->dev);
+		list_del(&new_memtier->list);
+		put_device(&new_memtier->dev);
 		return ERR_PTR(ret);
 	}
 	memtier = new_memtier;