Skip to content

Commit

Permalink
iommu/fsl: fix all kernel-doc warnings in fsl_pamu.c
Browse files Browse the repository at this point in the history
Fix kernel-doc warnings as reported by the kernel test robot:

fsl_pamu.c:192: warning: expecting prototype for pamu_config_paace(). Prototype was for pamu_config_ppaace() instead
fsl_pamu.c:239: warning: Function parameter or member 'omi_index' not described in 'get_ome_index'
fsl_pamu.c:239: warning: Function parameter or member 'dev' not described in 'get_ome_index'
fsl_pamu.c:332: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * Setup operation mapping and stash destinations for QMAN and QMAN portal.
fsl_pamu.c:361: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * Setup the operation mapping table for various devices. This is a static

Fixes: 695093e ("iommu/fsl: Freescale PAMU driver and iommu implementation.")
Fixes: cd70d46 ("iommu/fsl: Various cleanups")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: lore.kernel.org/r/[email protected]
Cc: Aditya Srivastava <[email protected]>
Cc: Joerg Roedel <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Robin Murphy <[email protected]>
Cc: [email protected]
Cc: Timur Tabi <[email protected]>
Cc: Varun Sethi <[email protected]>
Cc: Emil Medve <[email protected]>
Reviewed-by: Lu Baolu <[email protected]>
Acked-by: Timur Tabi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>
  • Loading branch information
rddunlap authored and joergroedel committed Mar 22, 2023
1 parent e8d018d commit 829a795
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/iommu/fsl_pamu.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ int pamu_update_paace_stash(int liodn, u32 value)
}

/**
* pamu_config_paace() - Sets up PPAACE entry for specified liodn
* pamu_config_ppaace() - Sets up PPAACE entry for specified liodn
*
* @liodn: Logical IO device number
* @omi: Operation mapping index -- if ~omi == 0 then omi not defined
Expand Down Expand Up @@ -232,7 +232,8 @@ int pamu_config_ppaace(int liodn, u32 omi, u32 stashid, int prot)
/**
* get_ome_index() - Returns the index in the operation mapping table
* for device.
* @*omi_index: pointer for storing the index value
* @omi_index: pointer for storing the index value
* @dev: target device
*
*/
void get_ome_index(u32 *omi_index, struct device *dev)
Expand Down Expand Up @@ -328,7 +329,7 @@ u32 get_stash_id(u32 stash_dest_hint, u32 vcpu)
#define QMAN_PORTAL_PAACE 2
#define BMAN_PAACE 3

/**
/*
* Setup operation mapping and stash destinations for QMAN and QMAN portal.
* Memory accesses to QMAN and BMAN private memory need not be coherent, so
* clear the PAACE entry coherency attribute for them.
Expand Down Expand Up @@ -357,7 +358,7 @@ static void setup_qbman_paace(struct paace *ppaace, int paace_type)
}
}

/**
/*
* Setup the operation mapping table for various devices. This is a static
* table where each table index corresponds to a particular device. PAMU uses
* this table to translate device transaction to appropriate corenet
Expand Down

0 comments on commit 829a795

Please sign in to comment.