Fix working with raw git diff #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix getting `baseSha` and `headSha`. Now I get `baseSha` from first commit, and `headSha` is got from the last commit. Need to sort commits by author date to be ordered chronologically - Reverted `baseSha` and `headSha` when computing `git diff` - Due to swapping `baseSha` and `headSha` also swapped additions and deletions in computation lambdas Closes danger#250
Vacxe
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem is described in #250. Here what I made and why:
baseShaandheadSha. Now I getbaseShafrom first commit, andheadShais got from the last commit. Need to sort commits by author date to be ordered chronologically, because differents APIs return commits in different order. For example, based on quote from GitHub documentation:API returns commits in chronological order, but GitLab API says thatthe commits are shown in reverse chronological order.baseShaandheadShawhen computinggit diffinKtxGitfile, because order of the commits matters on how diff is shown (additions and deletions are swapped)baseShaandheadShaalso swapped additions and deletions in computation lambdasCloses #250