Add optional capture-output writer to run_app() #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output and exit code of run_app() are now testable, used for diff test.
th1000s
force-pushed
the
capture_writer
branch
from
1a4c01b to
32214b9
Compare
dandavison
reviewed
Nov 5, 2024
| ); | ||
| let mut runargs = vec![OsString::from(file_a), OsString::from(file_b)]; | ||
| runargs.extend(args.iter().map(OsString::from)); | ||
| let exit_code = crate::run_app(runargs, Some(&mut writer)); |
There was a problem hiding this comment.
This is a nice improvement; I like that it is now more end-to-end.
|
[I'll leave you to merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output and exit code of
run_app()are now testable, used for diff test.For librarification, and generalized subcommands