Add truncate_str_short() which always returns a prefix of the input #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the input of `truncate_str()` may be cut on a double width
char ("fullwidth") - then the output is no longer a prefix of the input.
`truncate_str_short()` could be faster by not constructing the result but
only returning an index, but it will be used in rare edge cases so reusing
existing logic is good enough.
Common code moved to `truncate_str_impl()`.
Assume (with fallback) that graphemes are at most 2 wide.
Fewer allocations.
Tests.
dandavison
reviewed
Jul 17, 2024
| /// the resulting string is *shorter* than `display_width`. But this way the result is always a | ||
| /// prefix of the input `s`. | ||
| pub fn truncate_str_short(s: &str, display_width: usize) -> Cow<str> { | ||
| truncate_str_impl(s, display_width, "", None) |
There was a problem hiding this comment.
clippy wants #[allow(dead_code)] here
There was a problem hiding this comment.
I'll just merge it with the --max-syntax-highlighting-length PR :)
|
Now contained in PR #1746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that the input of
truncate_str()may be cut on a double width char ("fullwidth") - then the output is no longer a prefix of the input.truncate_str_short()could be faster by not constructing the result but only returning an index, but it will be used in rare edge cases so reusing existing logic is good enough.Common code moved to
truncate_str_impl().Assume (with fallback) that graphemes are at most 2 wide.
Fewer allocations.
Tests.