feat: remove redirect when creating custom feed from sidebar #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
changed the title
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
|
@AmarTrebinjac where does this request come from? |
It was just a self initiative based on personal experience and recalling this feedback 😅 |
|
@AmarTrebinjac This should be product driven, let's leave it for v2 changes they coming soon 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently when clicking the create custom feed modal it redirects you to /feeds/new. This has no real effect, but can seem a bit jarring to the user. This change opens the modal on the page where it was clicked.
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-773.preview.app.daily.dev