chore: cleanup plus to be available to all #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ilasw
requested changes
Jan 23, 2025
Comment on lines
82
to
84
| if (!menuItems.length) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think that we should remove this if at all, condition were: If there are no custom feeds AND the user is not entrolled to Plus
There was a problem hiding this comment.
Makes sense! Yes, let's remove this one.
ilasw
approved these changes
Jan 23, 2025
AmarTrebinjac
approved these changes
Jan 23, 2025
sshanzel
commented
Jan 23, 2025
| ...getPostByIdKey(post?.id), | ||
| { | ||
| key: 'title', | ||
| showPlusSubscription, |
There was a problem hiding this comment.
@omBratteng do you think we still need to have this property for the QueryKey? Like
{
key: 'title',
showPlusSubscription: true
}
|
I checked the areas where we made changes and they still exist/look the same against current prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-768.preview.app.daily.dev