Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase z-index to make button clickable #4088

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix: increase z-index to make button clickable #4088

merged 3 commits into from
Jan 21, 2025

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Jan 20, 2025 •
edited by github-actions bot
Loading

Changes

Recent changes where converting the user list link to be an absolute overlay rather than a link that nests buttons caused this menu to become un-clickable

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-767.preview.app.daily.dev

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review January 20, 2025 22:06
@AmarTrebinjac AmarTrebinjac requested a review from a team as a code owner January 20, 2025 22:06
@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 21, 2025 9:25am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 21, 2025 9:25am

rebelchris
rebelchris reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doesn't this break now when something sits on top where you click the wrong thing?

@AmarTrebinjac
Copy link
Contributor Author

But doesn't this break now when something sits on top where you click the wrong thing?

@rebelchris I'm not sure what you mean?

@rebelchris
Copy link
Contributor

@AmarTrebinjac for instance if a modal sits on top of this render, does it not click this button underlying?

@AmarTrebinjac
Copy link
Contributor Author

@AmarTrebinjac for instance if a modal sits on top of this render, does it not click this button underlying?

@rebelchris Hmm, it might in theory I guess, but this button is already in a modal itself, and I don't think we'll be popping another one on top of it 😅

@AmarTrebinjac
Copy link
Contributor Author

@rebelchris Changed it to z-1 since that works as well :)

@AmarTrebinjac AmarTrebinjac merged commit 3341ca4 into main Jan 21, 2025
9 of 10 checks passed
@AmarTrebinjac AmarTrebinjac deleted the MI-767 branch January 21, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmarTrebinjac @rebelchris