Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed firefox icon #4076

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

giuszeppe
Copy link
Contributor

Changes

I removed the Firefox icon since it is not supported.
Closes #1710

Copy link

vercel bot commented Jan 17, 2025

Someone is attempting to deploy a commit to the Daily Dev Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ AmarTrebinjac
✅ rebelchris
✅ sshanzel
❌ giuszeppe


giuszeppe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AmarTrebinjac
Copy link
Contributor

AmarTrebinjac commented Jan 19, 2025

Thank you for contributing, @giuszeppe ! We really appreciate it :)

Would you mind using the already existing edge/chrome icon? It's located here shared/src/components/icons/Browsers/group.svg

@sshanzel
Copy link
Member

Hi @giuszeppe. Kindly refer to Amar's comment, then I think we can delete the modified SVG file here. Thank you!

@@ -3,7 +3,7 @@ import React from 'react';
import type { ChecklistStepProps } from '../../lib/checklist';
import { ChecklistStep } from './ChecklistStep';
import { Button, ButtonVariant } from '../buttons/Button';
import BrowsersIcon from '../../../icons/browsers.svg';
import BrowsersIcon from '../icons/Browsers/group.svg';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you are now using the correct SVG. We can now just delete the modified file above.

@sshanzel sshanzel merged commit e8e79a1 into dailydotdev:main Jan 30, 2025
6 of 9 checks passed
@sshanzel
Copy link
Member

@giuszeppe thank you for your contribution! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Firefox Icon in Get Started With Squads
5 participants