-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed firefox icon #4076
Conversation
Someone is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
giuszeppe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thank you for contributing, @giuszeppe ! We really appreciate it :) Would you mind using the already existing edge/chrome icon? It's located here |
Hi @giuszeppe. Kindly refer to Amar's comment, then I think we can delete the modified SVG file here. Thank you! |
@@ -3,7 +3,7 @@ import React from 'react'; | |||
import type { ChecklistStepProps } from '../../lib/checklist'; | |||
import { ChecklistStep } from './ChecklistStep'; | |||
import { Button, ButtonVariant } from '../buttons/Button'; | |||
import BrowsersIcon from '../../../icons/browsers.svg'; | |||
import BrowsersIcon from '../icons/Browsers/group.svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you are now using the correct SVG. We can now just delete the modified file above.
This reverts commit 421e8f0.
@giuszeppe thank you for your contribution! 🙌 |
Changes
I removed the Firefox icon since it is not supported.
Closes #1710