feat: add custom prompt buttons to post content #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
rebelchris
reviewed
Jan 3, 2025
packages/shared/src/components/post/customPrompts/PromptButtons.tsx
Outdated
Show resolved
Hide resolved
rebelchris
requested changes
Jan 3, 2025
packages/shared/src/components/post/common/PostClickbaitShield.tsx
Outdated
Show resolved
Hide resolved
| icon={ | ||
| <PromptIcon | ||
| size={IconSize.XSmall} | ||
| className={!active && `text-accent-${flags.color}-default`} |
There was a problem hiding this comment.
This will break tailwind, we should probably actually do a manual map function that fully qualifies or store full classnames?
There was a problem hiding this comment.
| threshold={50} | ||
| /> | ||
| </Tab> | ||
| <Tab label={PromptDisplay.SimplifyIt}>simplify</Tab> |
There was a problem hiding this comment.
We can load these from the query now.
There was a problem hiding this comment.
I refactored it a bit. Either it didn't work react wise, or TypeScript weren't happy.
So now there's less available Tabs, as we can actually just re-use them when for streaming the content.
| @@ -14,6 +15,20 @@ export type Prompt = { | |||
| flags?: PromptFlags; | |||
| }; | |||
|
|
|||
| export enum PromptDisplay { | |||
There was a problem hiding this comment.
This can't really be a enum right considering they are dynamic and will change over time.
Co-authored-by: Chris Bongers <[email protected]>
rebelchris
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-905
Preview domain
https://as-905-post.preview.app.daily.dev