Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting addition #4035

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Jan 3, 2025

Changes

Added the specific settings and storing of them. (Applies to all feeds)

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

AS-904 #done

Preview domain

https://as-904-setting-addition.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner January 3, 2025 07:22
@rebelchris rebelchris requested review from omBratteng, ilasw, capJavert, sshanzel, nensidosari and AmarTrebinjac and removed request for a team January 3, 2025 07:22
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 3, 2025 9:58am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 3, 2025 9:58am

@rebelchris rebelchris requested a review from omBratteng January 3, 2025 09:56
Copy link
Member

@omBratteng omBratteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rebelchris rebelchris merged commit 0a3f255 into feat-custom-prompts Jan 3, 2025
10 checks passed
@rebelchris rebelchris deleted the AS-904-setting-addition branch January 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants