feat: v2 of custom feeds #4028
Merged
feat: v2 of custom feeds #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebelchris
requested review from
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
rebelchris
commented
Dec 30, 2024
idoshamun
approved these changes
Dec 30, 2024
idoshamun
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is v2 of custom feeds.
Main focus lies around uniforming behaviour and giving enrolled users a taste of the options we provide.
Flows:
Non enrolled existing plus:
Can see feed, can only change name/delete it
Can create new feeds, but they don't do anything
Enrolled non plus:
Can see feed and all options, they get stored
Can't see the actual feed load
Plus:
Can do all the things
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-899 #Done
Preview domain
https://as-899-custom-feed-v2.preview.app.daily.dev