Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom feed plus #3963

Merged
merged 51 commits into from
Dec 20, 2024
Merged

feat: custom feed plus #3963

merged 51 commits into from
Dec 20, 2024

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Dec 11, 2024

Changes

... 💦

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

AS-814 #done

Preview domain

https://as-814-custom-feeds-plus.preview.app.daily.dev

@capJavert capJavert self-assigned this Dec 11, 2024
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Dec 20, 2024 1:53pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Dec 20, 2024 1:53pm

@@ -35,6 +35,7 @@ const unBlockPromptOptions: PromptOptions = {
},
};

// TODO-AS-814 remove and replace instances with FeedSettingsEdit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capJavert This is still open?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo, too much files to check one by one

@capJavert capJavert merged commit 0e9ffd1 into main Dec 20, 2024
10 checks passed
@capJavert capJavert deleted the AS-814-custom-feeds-plus branch December 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants