fix: transform body into null when having null body status (#26)

* fix: transform body into null when having null body status * Bump
daangn · Oct 23, 2023 · dbe98be · dbe98be
1 parent 6375ddc
commit dbe98be
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/.changeset/wet-schools-sort.md b/.changeset/wet-schools-sort.md
@@ -0,0 +1,5 @@
+---
+"plantae": patch
+---
+
+fix: transform body into null when having null body status
diff --git a/packages/plantae/src/axios/createAxiosInterceptors.ts b/packages/plantae/src/axios/createAxiosInterceptors.ts
@@ -7,7 +7,7 @@ import type {
 
 import createMiddleware from "../createMiddleware";
 import type { AdapterRequest, AdapterResponse, Plugin } from "../types";
-import { isArrayBuffer } from "../utils";
+import { isArrayBuffer, isNullBodyStatus } from "../utils";
 
 type InterceptorType = keyof AxiosInstance["interceptors"];
 
@@ -127,11 +127,18 @@ function convertToAdapterResponse(res: AxiosResponse): AdapterResponse {
     (res.config.responseType === "json" ||
       (!res.config.responseType && res.config.transitional?.forcedJSONParsing));
 
-  return new Response(isJSONBody ? JSON.stringify(res.data) : res.data, {
-    status: res.status,
-    statusText: res.statusText,
-    headers: new Headers(headers.toJSON(true) as HeadersInit),
-  });
+  return new Response(
+    isJSONBody
+      ? JSON.stringify(res.data)
+      : isNullBodyStatus(res.status)
+      ? null
+      : res.data,
+    {
+      status: res.status,
+      statusText: res.statusText,
+      headers: new Headers(headers.toJSON(true) as HeadersInit),
+    }
+  );
 }
 
 async function extendClientResponse(

diff --git a/packages/plantae/src/utils.ts b/packages/plantae/src/utils.ts
@@ -9,3 +9,7 @@ const kindOfTest = (type: string) => {
 };
 
 export const isArrayBuffer = kindOfTest("ArrayBuffer");
+
+// https://fetch.spec.whatwg.org/#statuses
+export const isNullBodyStatus = (status: number) =>
+  [101, 103, 204, 205, 304].includes(status);