Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Update number formatting for braf-fusion plots (5/N) #68

Merged
merged 7 commits into from
May 13, 2024

Conversation

rjcorb
Copy link
Contributor

@rjcorb rjcorb commented Apr 17, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are

soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are

ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the
    project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to
    date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb changed the title Update number formatting for braf-fusion plots Update number formatting for braf-fusion plots (5/N) Apr 17, 2024
@rjcorb rjcorb requested review from naqvia and jharenza April 30, 2024 20:37
@naqvia
Copy link

naqvia commented May 1, 2024

I continue to get this error related to Docker (I have pulled latest version and ran that):

root@0685d9fd2d0b:/home/rstudio/pbta-ancestry/analyses/braf-fusions# bash run_module.sh

processing file: 01-get-breakpoint-exons.Rmd
|... | 9% (load libraries and set directories)Quitting from lines 16-27 (01-get-breakpoint-exons.Rmd)
Error in library(GenomicRanges) :
there is no package called 'GenomicRanges'
Calls: ... withVisible -> eval_with_user_handlers -> eval -> eval -> library

Execution halted

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I see the braf changes I mentioned in #67 here.

@jharenza
Copy link
Collaborator

jharenza commented May 8, 2024

just noting that once #67 is merged, and merged into this PR, this PR will need a rerun before merge

Copy link

@naqvia naqvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from rjcorb/65-format-survival-numbers to main May 13, 2024 20:42
@rjcorb rjcorb merged commit 72909f1 into main May 13, 2024
@rjcorb rjcorb deleted the rjcorb/66-braf-fusion-update branch May 13, 2024 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants