-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update MB SHH abridged output #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @rjcorb are the mutation calls being removed expected here?
@jharenza I reran the script and am still getting those changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks should all pass now, but can you double check re: my comments above - is your data linked to v15, not testing or something odd by chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjcorb I just reran the full module and committed results so we are all set on this now
module of interest passed checks |
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR updates the
molecular-subtyping-MB
analysis module to remove non-relevant columns from abridged output generated by05-subtype-mb-shh.R
.What was your approach?
Removed
SHH_subtype
column frommb_shh_molecular_subtypes.tsv
, sincemolecular_subtype
column contains complete information on SHH subtype classification.What GitHub issue does your pull request address?
#599
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.