Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manuscript: Generate tables #588

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update manuscript: Generate tables #588

merged 2 commits into from
Jul 1, 2024

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jun 27, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

Generate tables for OpenPedCan manuscript

What was your approach?

generate and rename:

  1. histologies table
  2. molecular subtype/MB-SHH subtype
  3. software

What GitHub issue does your pull request address?

https://github.com/d3b-center/OpenPedCan-manuscript/issues/108

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from jharenza June 27, 2024 15:06
@zzgeng zzgeng requested a review from a team as a code owner June 27, 2024 15:06
@@ -0,0 +1,19 @@
#!/bin/bash
# Module author: Aditya Lahiri
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Module author: Aditya Lahiri
# Module author: Zhuangzhuang Geng

@jharenza jharenza self-requested a review July 1, 2024 21:09
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! changed one colname from Samples to Tumors in S2, and removed the S2-hist table, but otherwise looks good. We can merge for now and update once the MB subtyping is done

@jharenza jharenza merged commit e289e49 into dev Jul 1, 2024
27 checks passed
@jharenza jharenza deleted the zzgeng/supp_table branch July 1, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants