feat: roll back to superenv yet keep path injection #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d12frosted
force-pushed
the
feature/env-fixes
branch
from
2d51cd4 to
5f4d694
Compare
It turns out all these tricks we are doing with path are not needed as there is a way to access original path via `ORIGINAL_PATHS` variable. This means that we can keep the stable super env while still injecting path.
d12frosted
force-pushed
the
feature/env-fixes
branch
from
5f4d694 to
fb2f2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out all these tricks we are doing with path are not needed as there is a way to access original path via
ORIGINAL_PATHSvariable. This means that we can keep the stable super env while still injecting path.P.S. this kind of like a dev branch