Support reading PWS passwords from stdin #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the pws set subcommand as part of the PWS interface refactoring. Users should use pws add (for writing to new slots) or pws update (for writing to existing slots) instead. This makes it less likely to accidentally overwrite PWS data.
This reverts commit ba2311e. The previous patch removed the code that caused problems with the MSRV (u8::MIN and u8::MAX), so we no longer have to increase it.
Specifying passwords as command-line arguments can be problematic: The user has to be careful that the command is not recorded in the shell history. Also, the password might be exposed over the process list. This patch adds an alternative input method for the pws add and pws update methods: reading the password from stdin. This is activated by setting the password to "-". For the tests, we use a string as a simulated stdin buffer.
|
Very nice change. Thanks Robin! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying passwords as command-line arguments can be problematic: The
user has to be careful that the command is not recorded in the shell
history. Also, the password might be exposed over the process list.
This patch adds an alternative input method for the pws add and pws
update methods: reading the password from stdin. This is activated by
setting the password to "-". For the tests, we use a string as a
simulated stdin buffer.
This patch is part of the PWS interface refactoring discussed in #139 and is based on #162.