Add overwrite option to pws set command #157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the --overwrite option to the pws set command and
changes the default behavior to refuse overwriting programmed slots.
I originally suggested this change in #139 but I think I’ve changed my mind: This form of the
pws set
command is pretty useless. If I want to overwrite a slot I should rather usepws update
. If I want to add a new slot I most likely want to usepws add
. Only if I want to set a specific slot I needpws set
.At the same time, changing the default behavior is a already breaking change. Why not remove
pws set
completely while at it and add a--slot
option topws add
if I really want to write a specific slot?