Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Черепанов Иван Александрович #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jopick
Copy link

@Jopick Jopick commented Dec 5, 2024

No description provided.

add_test(NAME two-sum-test COMMAND two-sum-test)
include(GoogleTest)
gtest_discover_tests(two-sum-test)
#find_package(GTest REQUIRED)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не надо было это коммитить и пушить, сейчас из-за этого не заработают тесты в GitHub Actions

for(size_t i = 0; i < ARRAY_SIZE - 1; i ++) {
for(size_t j = i + 1; j < ARRAY_SIZE; j++){
if(nums[i] + nums[j] == target) {
if(nums[i] < nums[j]){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем нужна эта проверка?

@Jopick Jopick requested a review from czertyaka December 8, 2024 12:03
Copy link
Owner

@czertyaka czertyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Повторный запрос измнений. Вы наверное мое ревью запросили случайно. Надо добавить коммиты с исправлениями, тогда мое ревью авторматически запросится

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants