Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2026: allocate shared memory if the tool is configured to use it #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slr71
Copy link
Member

@slr71 slr71 commented Jan 10, 2025

This change allows DE administrators to indicate that an app should have shared memory allocated to it for tools that require shared memory. We provide the shared memory by creating an emptyDir volume with the size limit specified by the tool. (See this StackOverflow answer for more details.)

This is implemented in a similar way to our GPU integration. To dedicate shared memory to a tool add a container device to the tool with a host path of /dev/shm and a container path equal to the amount of shared memory to make available:
image

It's not a perfect way to indicate how much shared memory should be provided, but implementing it this way allowed us to make this feature available quickly.

Copy link
Contributor

@johnworth johnworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I can think of is to move "/dev/shm" references into a constant, but that's minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants