Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put unbundled edges in a separate key in the control point table #3323

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

maxkfranz
Copy link
Member

@maxkfranz maxkfranz commented Jan 15, 2025

Cross-references to related issues. If there is no existing issue that describes your bug or feature request, then create an issue before making your pull request.

Associated issues:

Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.

Debug page before:

Screenshot 2025-01-15 at 15 57 33

Debug page after:

Screenshot 2025-01-15 at 15 58 04

You can see in the debug page (npm run watch) that the parallel edges in f34682c are incorrect without the fix, and they are correct with the fix in a16b04e.

Parallel edges without the fix. Note that the beziers are incorrect with the unbundled, bent edge in there:

Screenshot 2025-01-15 at 15 58 04

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).
  • For new or updated API, the index.d.ts Typescript definition file has been appropriately updated.

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

- It should show what the library does by default as much as possible.
- Add edge for: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322

Ref: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322
…ints

Ref: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant