Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/apply isort linting checks #389

Merged

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Mar 30, 2024

Description

Should be merged after #386 .
This applies isort to pycytominer except in the cyto_utils submodule.
cyto_utils was excluded due to the presence of circular dependencies documented in #372

Note: For review purposes this is currently targeting the branch cytomining:ci/update-ruff-to-0.3.4. It will be switched to target main after that branch is merged.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://pycytominer--389.org.readthedocs.build/en/389/

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (af5a4ef) to head (26e2579).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          56       56           
  Lines        3137     3137           
=======================================
  Hits         2979     2979           
  Misses        158      158           
Flag Coverage Δ
unittests 94.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenibrewer kenibrewer changed the base branch from main to ci/update-ruff-to-0.3.4 March 30, 2024 19:42
@kenibrewer kenibrewer requested a review from d33bs March 30, 2024 19:53
@kenibrewer kenibrewer marked this pull request as ready for review March 30, 2024 19:53
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ isort, great additions! LGTM. Appreciate the mention about the existing issue with circular imports in cyto_utils.

@kenibrewer kenibrewer changed the base branch from ci/update-ruff-to-0.3.4 to main April 2, 2024 01:59
@kenibrewer kenibrewer merged commit 193f673 into cytomining:main Apr 2, 2024
12 checks passed
@kenibrewer kenibrewer deleted the refactor/apply-isort-linting-checks branch April 2, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants