Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Updated mismatched dependencies warning message to be neutral #31011

Merged

Conversation

tarunmaini16
Copy link
Contributor

Additional details

This change was done to provide helpful debugging steps to user, in case of version mismatch occur in dependencies

Steps to test

  • Install a lower version of React (e.g 15.6)
  • Run latest version of cypress
  • Install dependencies
  • Observe a warning message:

How has the user experience changed?

  • Before fix: If you're experiencing problems, downgrade dependencies and restart Cypress.
  • After fix. : If you're experiencing problems, ensure your dependencies are on a supported version and restart Cypress.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@tarunmaini16 tarunmaini16 changed the title Updated mismatched dependencies warning message to be neutral refactor: Updated mismatched dependencies warning message to be neutral Feb 3, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane jennifer-shehane changed the title refactor: Updated mismatched dependencies warning message to be neutral misc: Updated mismatched dependencies warning message to be neutral Feb 3, 2025
@jennifer-shehane jennifer-shehane self-requested a review February 3, 2025 18:15
@jennifer-shehane
Copy link
Member

@tarunmaini16 Thanks for you contribution! Could you add a changelog entry under the misc category? Following these instructions? https://github.com/cypress-io/cypress/blob/develop/guides/writing-the-cypress-changelog.md

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be g2g once we have a changelog entry

@jennifer-shehane jennifer-shehane removed the request for review from astone123 February 4, 2025 18:55
@jennifer-shehane jennifer-shehane merged commit e8e2d92 into cypress-io:develop Feb 4, 2025
70 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 5, 2025

Released in 14.0.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.0.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CT: Mismatched dependencies wording says 'downgrade' when it could also need to mean 'upgrade'
6 participants