fix: support multiple imports of one module with multiple lines

[wenfw]

The . in RegExp matches all characters except line terminators, so the following won't match:

import {
  a,
  b,
  c,
} from 'x';

Changing it to [^;'"] allows it to match all characters, including \n, except for ;'", which resolves the issue.

Using the current regular expression /(?<=^|\s)import (.+?) from ['"](.*?)['"]/g will cause the new test cases to fail.

Additional details

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@wenfw Could you write a test for this change?

[wenfw]

@wenfw Could you write a test for this change?

@jennifer-shehane Test cases have been updated. Thanks.

[AtofStryker]

Hi @wenfw. Thank you for the contribution! At first glance I am not sure exactly what this is solving. Can you add a more descriptive PR description to describe the current problem and how your solution addresses that problem?

[wenfw]

@AtofStryker The . in RegExp matches all characters except line terminators, so the following won't match:

import {
  a,
  b,
  c,
} from 'x';

Changing it to [^;'"] allows it to match all characters, including \n, except for ;'", which resolves the issue.

Using the current regular expression /(?<=^|\s)import (.+?) from ['"](.*?)['"]/g will cause the new test cases to fail.

[allexiusw]

LGTM

[AtofStryker]

@wenfw everything looks good. Are you able to add a changelog entry?

[MikeMcC399]

@AtofStryker

I'm not sure if this PR has gone through correctly regarding changelog and release.

1. If the PR only affects npm/vite-plugin-cypress-esm then I believe that the npm/vite-plugin-cypress-esm/CHANGELOG.md entry is created automatically on a successful release, so there shouldn't be an entry for this PR in cli/CHANGELOG.md.
2. Although the PR has merged into the develop branch, the merge has CircleCI failures, so no release was carried out. See https://app.circleci.com/pipelines/github/cypress-io/cypress/65765, meaning also that there is no npm/vite-plugin-cypress-esm/CHANGELOG.md created yet.

• I just happened to notice because PR fix: prevent overwriting of video files #30673 is getting tripped up on the incorrect cli/CHANGELOG.md created by this PR. The error wasn't however picked up in this PR as the changelog linting said:

  Does not contain changes that impacts the next Cypress release.

[jennifer-shehane]

@MikeMcC399 Thanks for surfacing! We're looking into this.

[AtofStryker]

Looks like this released yesterday to npm https://www.npmjs.com/package/@cypress/vite-plugin-cypress-esm. When the percy job fails it is fairly hard to rectify and usually means it will release on the next passing merge to develop, which happened to be 06aeb9d (which also removes the entry).

[cypress-bot]

Released in 13.16.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.16.1, please open a new issue.