Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check towncrier message format in lint ci #6216

Closed
wants to merge 1 commit into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jul 10, 2024

Oliver and I have both now made the mistake of mis-forming the towncrier messages, so here's an auto-check.

Example of it failing (correctly) on master
https://github.com/wxtim/cylc/actions/runs/9871865449/job/27260726283

@wxtim wxtim self-assigned this Jul 10, 2024
@wxtim wxtim added efficiency For notable efficiency improvements could be better Not exactly a bug, but not ideal. labels Jul 10, 2024
@wxtim wxtim added this to the 8.3.x milestone Jul 10, 2024
@MetRonnie
Copy link
Member

Hopefully we can get this implemented in towncrier itself: twisted/towncrier#622

@wxtim wxtim marked this pull request as draft July 11, 2024 09:52
@wxtim
Copy link
Member Author

wxtim commented Jul 11, 2024

Drafted pending outcome of @MetRonnie 's proposed changes to Towncrier.

@MetRonnie MetRonnie added infrastructure GH Actions, Codecov etc. and removed efficiency For notable efficiency improvements labels Jul 11, 2024
@wxtim
Copy link
Member Author

wxtim commented Jul 19, 2024

Good progress on twisted/towncrier#622

@wxtim wxtim closed this Jul 22, 2024
@wxtim wxtim deleted the check_towncrier_message_form branch July 22, 2024 10:38
@MetRonnie MetRonnie mentioned this pull request Jul 30, 2024
8 tasks
@oliver-sanders oliver-sanders removed this from the 8.3.x milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. infrastructure GH Actions, Codecov etc. superseded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants