fix: jsonMerge with complex json literals #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
force-pushed
the
fix-json-merge-escape
branch
from
14bff78 to
b1d1318
Compare
cyjake
force-pushed
the
fix-json-merge-escape
branch
from
b1d1318 to
e58b4a6
Compare
cyjake
commented
Jan 9, 2025
| "sqlite3": { | ||
| "glob": "11.0.0", | ||
| "node-gyp": "10.2.0" | ||
| } |
There was a problem hiding this comment.
cyjake
commented
Jan 9, 2025
| if [ "$file" != test/integration/sqlcipher.test.js ]; then | ||
| run ${file}; | ||
| fi | ||
| done |
There was a problem hiding this comment.
ubuntu 22 升级到了 openssl 3，sqlcipher 编译用的还是 1.1，降级起来有点麻烦，先从默认的 CI 任务里面摘出来，必要的时候手动跑
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 96.78% 96.79% +0.01%
==========================================
Files 45 45
Lines 3700 3716 +16
Branches 72 72
==========================================
+ Hits 3581 3597 +16
Misses 105 105
Partials 14 14 ☔ View full report in Codecov by Sentry. |
JimmyDaddy
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att