Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Update README.md #10

merged 5 commits into from
Oct 28, 2024

Conversation

bmeyers
Copy link
Member

@bmeyers bmeyers commented Oct 22, 2024

No description provided.

@bmeyers
Copy link
Member Author

bmeyers commented Oct 22, 2024

@pluflou I think I'm going to need your help here when you're available again 🙏

@bmeyers bmeyers requested a review from pluflou October 22, 2024 23:36
@bmeyers
Copy link
Member Author

bmeyers commented Oct 28, 2024

@pluflou tests now pass 🎉 can you provide your review for the PR?

this was the root cause of the numpy failures in the tests: https://numpy.org/doc/stable/reference/generated/numpy.linalg.solve.html

Changed in version 2.0: The b array is only treated as a shape (M,) column vector if it is exactly 1-dimensional. In all other instances it is treated as a stack of (M, K) matrices. Previously b would be treated as a stack of (M,) vectors if b.ndim was equal to a.ndim - 1.

Copy link
Member Author

@bmeyers bmeyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to the workflows (deleting the conda stuff) looks good to me!

@bmeyers bmeyers merged commit f79886a into main Oct 28, 2024
2 checks passed
@bmeyers bmeyers deleted the bmeyers-patch-1 branch October 28, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants