Added threshold parameter to detector runner
#9011
Merged
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why 0.9? Our Nuclio functions default to 0.5, and so do Roboflow/HF functions; seems like we should do the same to preserve the default behavior. |
|
IMHO it should be optional and default value should be |
3 tasks
|
May you update couple of docs here https://docs.cvat.ai/docs/manual/advanced/automatic-annotation/ Screenshots + describe threshold parameter |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9011 +/- ##
===========================================
- Coverage 73.43% 73.43% -0.01%
===========================================
Files 418 418
Lines 44299 44299
Branches 3870 3870
===========================================
- Hits 32533 32532 -1
- Misses 11766 11767 +1
|
|
|
Documentation will be updated here: #8853 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Added an input field to detector runner with threshold parameter. The parameter already supported by the server.
By default the parameter is undefined and UI lets the server decide what threshold to use.
How has this been tested?
Checklist
developbranch[ ] I have added tests to cover my changesLicense
Feel free to contact the maintainers if that's a concern.