Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly cleaned up cypress tests #8975

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 21, 2025

Motivation and context

  1. For us there should not be difference between clearAllCookies and clearCookies as we only use one domain. Thus using clearAllCookies was removed.
  2. Minimized using of clearCookies, preferred custom command headlessLogout

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from azhavoro as a code owner January 21, 2025 14:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (5a99e73) to head (efe12ce).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8975      +/-   ##
===========================================
+ Coverage    73.84%   73.86%   +0.02%     
===========================================
  Files          417      417              
  Lines        44589    44590       +1     
  Branches      4031     4031              
===========================================
+ Hits         32926    32937      +11     
+ Misses       11663    11653      -10     
Components Coverage Δ
cvat-ui 78.34% <ø> (+0.04%) ⬆️
cvat-server 70.06% <ø> (ø)

@bsekachev bsekachev merged commit cc4c910 into develop Jan 21, 2025
34 checks passed
@bsekachev bsekachev deleted the bs/slightly_cleanup_cypress branch January 22, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants