Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comment #8868

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore: fix some typos in comment #8868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cvat-core/src/annotations-actions/base-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
}, {} as Record<string, string | number>);
}

export function validateClientIDs(collection: Partial<SerializedCollection>) {

Check warning on line 50 in cvat-core/src/annotations-actions/base-action.ts

View workflow job for this annotation

GitHub Actions / Linter 

Missing return type on function
[].concat(
collection.shapes ?? [],
collection.tracks ?? [],
collection.tags ?? [],
).forEach((object) => {
// clientID is required to correct collection filtering and commiting in annotations actions logic
// clientID is required to correct collection filtering and committing in annotations actions logic
if (typeof object.clientID !== 'number') {
throw new Error('ClientID is undefined when running annotations action, but required');
}
Expand Down
2 changes: 1 addition & 1 deletion cvat-core/src/annotations-actions/base-shapes-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export async function run(
}
}

await showMessageWithPause('Commiting handled objects', 100, 1500);
await showMessageWithPause('Committing handled objects', 100, 1500);
if (cancelled()) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion cvat-ui/src/utils/is-able-to-change-frame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function isAbleToChangeFrame(frame?: number): boolean {
if (typeof frame === 'number') {
if (meta.includedFrames) {
// frame argument comes in job coordinates
// hovewer includedFrames contains absolute data values
// however includedFrames contains absolute data values
frameInTheJob = meta.includedFrames.includes(meta.getDataFrameNumber(frame - job.startFrame));
}

Expand Down
2 changes: 1 addition & 1 deletion helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ ingress:
## kubernetes.io/ingress.class: nginx
##
annotations: {}
## @param ingress.className IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+)
## @param ingress.className IngressClass that will be used to implement the Ingress (Kubernetes 1.18+)
## This is supported in Kubernetes 1.18+ and required if you have more than one IngressClass marked as the default for your cluster
## ref: https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/
##
Expand Down
Loading