-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Serverless tutorial
documentation
#8853
Conversation
Removed Masked RCNN
Removed masked rcnn from overview
removed mentions of Mask RCNN
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces comprehensive updates to CVAT's documentation across multiple files. The changes focus on enhancing user understanding by providing more detailed information about the tool's capabilities, annotation formats, AI tools, and serverless functions. The updates span README.md, overview documentation, AI tools guide, and serverless tutorial, with improvements in content clarity, model descriptions, and deployment instructions. Changes
Sequence DiagramsequenceDiagram
participant User
participant CVAT
participant ServerlessFunction
participant AIModel
User->>CVAT: Select Annotation Task
CVAT->>ServerlessFunction: Deploy Serverless Function
ServerlessFunction->>AIModel: Load Pre-trained Model
User->>CVAT: Upload Image/Video
CVAT->>ServerlessFunction: Request Annotation
ServerlessFunction->>AIModel: Process Image
AIModel-->>ServerlessFunction: Return Annotations
ServerlessFunction-->>CVAT: Provide Annotation Results
CVAT-->>User: Display Annotated Data
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure if removing all mentions of Mask R-CNN from the documentation is the right approach.
First, we still support the CPU version of it.
Second, it would be better to replace the Mask R-CNN section in the tutorial with another existing GPU detector, such as Faster R-CNN. Writing a new tutorial may not need to be part of this PR, but at the very least, we should retain the CPU section
hi klakhov, thanks for the correction, I will correct it! |
Added mask RCNN as CPU version is still supported
I corrected it! Thanks for the feedback and sorry for the bad PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please avoid deleting the GPU deployment section of the tutorial in the documentation? Instead, consider updating it to reference another available GPU function from the repository.
I believe removing the GPU tutorial entirely is bad idea, as having a slightly outdated tutorial is still better than having none at all.
@klakhov Thanks for your patience. I am new to this project so I just made the changes without giving it much thought |
Quality Gate passedIssues Measures |
@prateekshukla1108 well now it looks better. |
Still trying to understand the Codebase. Also I have exams so I get very little time to work on Open Source. but I'll try |
Great!
I should work out of the box |
Actually I don't have access to GPU's. Most of my work is done in colab so its pretty difficult to test |
Serverless tutorial
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8853 +/- ##
===========================================
- Coverage 73.39% 73.38% -0.01%
===========================================
Files 416 416
Lines 44207 44207
Branches 3860 3860
===========================================
- Hits 32446 32443 -3
- Misses 11761 11764 +3
|
Quality Gate passedIssues Measures |
Removed mentions of Masked RCNN from the website and README
Updated detectors documentation screenshots, depends on #9011
Resolves #8851
Motivation and context
Mask RCNN was removed but the documentation and README wasn't modified
How has this been tested?
Just checked in the preview tab in github
Checklist
develop
branch[ ] I have created a changelog fragment Not needed[ ] I have added tests to cover my changes -> not needed[ ] I have linked related issues -> Not neededLicense
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation