v0.11.1 -> v0.11.2: take country into account when determining state fallback rate #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcain3389
force-pushed
the
fix-state-code-collision-bug
branch
from
2a82c08 to
9b1c9d1
Compare
danielwheeler1987
approved these changes
Jan 21, 2025
jcain3389
force-pushed
the
fix-state-code-collision-bug
branch
from
96723c1 to
c598411
Compare
jcain3389
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stakeholder Overview (learn more)
vertex_clientto v0.11.1 in thecheckoutapp, @lbeougher discovered a bug wherein an order shipping to Valladolid, Spain was being taxed at 5.65% (when it should've been taxed at 0%). Upon closer inspection, it was determined that this was the Virginia state tax, and it was being applied due to a collision in the state code ('VA', in this case). This PR fixes this pre-existing bug by taking a state's country into account when determine the proper fallback tax rate to apply.Risk Estimate (learn more)
Changes
Monday Item
vertex_clientfrom v0.11.1 to v0.11.2