Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template based on observed IRL usage #23

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

chmurph2
Copy link
Member

@chmurph2 chmurph2 commented Sep 4, 2024

Stakeholder Overview (learn more)

I'm recommending the following changes based on months of observing how these PR templates are typically used:

  1. Renames the ticket section to be more generic. Some teams prefer to link to the more informative project pitch than a (typically) vague Monday item.
  2. Makes the Risk Estimate description optional. Most are just leaving the "replace this with..." text as is.

Risk Estimate (learn more)

  • ✅ Negligible risk!

What GIF Best Describes This Pull Request?

1. Renames the ticket section to be more generic
2. Makes the Risk Estimate description optional
@chmurph2 chmurph2 requested review from a team as code owners September 4, 2024 16:54
Copy link
Member

@astupka astupka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Looks like this will handle the need to link project pitches too.

@chmurph2 chmurph2 merged commit 8375919 into master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants