refactor ValidateEmail method interface

bulkvalidate/bulkvalidate.go

@@ -143,7 +143,7 @@ func RunBulkValidation(inputFilePath, outputFilePath string) {
 		if err != nil {
 			log.Printf("Error: %s %s", email, err.Error())
 		}
-		emailResults, err := mailvalidate.ValidateEmail(request, syntaxResults)
+		emailResults, err := mailvalidate.ValidateEmail(request)
 		if err != nil {
 			log.Printf("Error: %s %s", email, err.Error())
 		}

internal/cmd/cmd.go

@@ -51,7 +51,7 @@ func VerifyEmail(email string) {
 	request := run.BuildRequest(email)
 	syntaxResults := VerifySyntax(email, false)
 	domainResults := VerifyDomain(syntaxResults.Domain, false)
-	emailResults, err := mailvalidate.ValidateEmail(request, syntaxResults)
+	emailResults, err := mailvalidate.ValidateEmail(request)
 	if err != nil {
 		fmt.Println(err)
 	}

internal/syntax/syntax_test.go

@@ -35,8 +35,8 @@ func TestIsValidEmailSyntax(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if got, _ := IsValidEmailSyntax(tt.email); got != tt.want {
-				t.Errorf("IsValidEmailSyntax(%q) = %v, want %v", tt.email, got, tt.want)
+			if isValid, _ := IsValidEmailSyntax(tt.email); isValid != tt.want {
+				t.Errorf("IsValidEmailSyntax(%q) = %v, want %v", tt.email, isValid, tt.want)
 			}
 		})
 	}

mailvalidate/validation.go

@@ -51,20 +51,20 @@ type SyntaxValidation struct {
 }
 
 func ValidateEmailSyntax(email string) SyntaxValidation {
-	var results SyntaxValidation
-	ok, cleanEmail := syntax.IsValidEmailSyntax(email)
-	if !ok {
-		return results
+	isValid, cleanEmail := syntax.IsValidEmailSyntax(email)
+	if !isValid {
+		return SyntaxValidation{}
 	}
 
 	user, domain, ok := syntax.GetEmailUserAndDomain(cleanEmail)
 	if !ok {
-		return results
+		return SyntaxValidation{}
+	}
+	return SyntaxValidation{
+		IsValid: true,
+		User:    user,
+		Domain:  domain,
 	}
-	results.IsValid = true
-	results.User = user
-	results.Domain = domain
-	return results
 }
 
 func ValidateDomain(validationRequest EmailValidationRequest, validateCatchAll bool) (DomainValidation, error) {
@@ -121,12 +121,13 @@ func ValidateDomainWithCustomKnownProviders(validationRequest EmailValidationReq
 	return results, nil
 }
 
-func ValidateEmail(validationRequest EmailValidationRequest, emailSyntaxResults SyntaxValidation) (EmailValidation, error) {
+func ValidateEmail(validationRequest EmailValidationRequest) (EmailValidation, error) {
 	var results EmailValidation
 	if err := validateRequest(&validationRequest); err != nil {
 		return results, errors.Wrap(err, "Invalid request")
 	}
-	if !emailSyntaxResults.IsValid {
+	emailSyntaxResult := ValidateEmailSyntax(validationRequest.Email)
+	if !emailSyntaxResult.IsValid {
 		return results, fmt.Errorf("Invalid email address")
 	}
 
@@ -140,7 +141,7 @@ func ValidateEmail(validationRequest EmailValidationRequest, emailSyntaxResults
 		log.Fatal(err)
 	}
 
-	email := fmt.Sprintf("%s@%s", emailSyntaxResults.User, emailSyntaxResults.Domain)
+	email := fmt.Sprintf("%s@%s", emailSyntaxResult.User, emailSyntaxResult.Domain)
 
 	isFreeEmail, err := IsFreeEmailCheck(email, freeEmails)
 	if err != nil {