Code

fixes from auditor comments#30

Code

Merged

bout3fiddy merged 73 commits intomaincurvefi/stableswap-ng:mainfrom fix/auditcurvefi/stableswap-ng:fix/auditCopy head branch name to clipboardNov 1, 2023

+4,527-2,299

Commits

Commits on Sep 13, 2023

• use dynamic fee instead of base fee

  bout3fiddy

  committed
  02c9ee0

  Copy full SHA for 02c9ee0

Commits on Sep 14, 2023

• mixbytes auditor comment. fix: gulp while transfer out; but gulp into stored_balances

  bout3fiddy

  committed
  5207bd1

  Copy full SHA for 5207bd1

Commits on Sep 15, 2023

• fix: use correct dx_w_fee in stored_balances

  bout3fiddy

  committed
  f376632

  Copy full SHA for f376632

• fix paranthesis

  bout3fiddy

  committed
  ef17510

  Copy full SHA for ef17510

Commits on Sep 19, 2023

• add D_ma_time for D_oracle

  bout3fiddy

  committed
  0c87415

  Copy full SHA for 0c87415

• do not add liquidity to base pool and incr

  Show description for 6b7dbdf
  bout3fiddy

  committed
  6b7dbdf

  Copy full SHA for 6b7dbdf

Commits on Sep 20, 2023

• fix: incorrect stored_balances update; fix: remove donation for non rebasing; fix: remove exchange_received for pools containing rebasing tokens; fix: remove unnecessary inputs in _transfer_in for …

  Show description for 8992bea
  bout3fiddy

  committed
  8992bea

  Copy full SHA for 8992bea

• fix: also restrict exchange_underlying_received

  bout3fiddy

  committed
  2c10cb3

  Copy full SHA for 2c10cb3

• fix pipeline

  amfet42

  committed
  79615f8

  Copy full SHA for 79615f8

• fix mock contract

  amfet42

  committed
  cc8cfb2

  Copy full SHA for cc8cfb2

Commits on Sep 21, 2023

• fix: dynamic fee; feat: introduce gauge manager; feat: add optional reward token epoch

  bout3fiddy

  committed
  8646209

  Copy full SHA for 8646209

• fix donation test

  amfet42

  committed
  b2161c0

  Copy full SHA for b2161c0

Commits on Sep 22, 2023

• fix: add admin slashing immunity comment to docstring

  bout3fiddy

  committed
  e6699d1

  Copy full SHA for e6699d1

• Merge branch 'fix/audit' of github.com:curvefi/stableswap-ng into fix/workflow

  amfet42

  committed
  7cde923

  Copy full SHA for 7cde923

• fix tests

  amfet42

  committed
  f946037

  Copy full SHA for f946037

• fix tests

  amfet42

  committed
  10db985

  Copy full SHA for 10db985

Commits on Sep 23, 2023

• Merge pull request #31 from curvefi/fix/workflow

  Show description for 2bab627
  bout3fiddy

  authored
  2bab627

  Copy full SHA for 2bab627

Commits on Sep 25, 2023

• fix: remove unneeded dynarray forming code

  bout3fiddy

  committed
  dcf88c7

  Copy full SHA for dcf88c7

Commits on Sep 26, 2023

• fix remove liquidity test

  amfet42

  committed
  be65254

  Copy full SHA for be65254

Commits on Sep 27, 2023

• fix: audit comments #2

  bout3fiddy

  committed
  2d5f374

  Copy full SHA for 2d5f374

• fix: do not multiple vprice if we need lp tokens for views method

  bout3fiddy

  committed
  8315d25

  Copy full SHA for 8315d25

• fix: tests

  bout3fiddy

  committed
  daff90b

  Copy full SHA for daff90b

• fix: disallow 0 transferFrom into the pool

  bout3fiddy

  committed
  496901e

  Copy full SHA for 496901e

• remove unused vars and rename internal fn

  bout3fiddy

  committed
  04d2fa4

  Copy full SHA for 04d2fa4

• check for zero token amt burning

  bout3fiddy

  committed
  9fa42a1

  Copy full SHA for 9fa42a1

• fix: use fraxusdc for add_base_pool test since that has coins(u: uint256) abi

  bout3fiddy

  committed
  d5adba9

  Copy full SHA for d5adba9

Commits on Sep 28, 2023

• do not disable _checkpoint_rewards entirely

  bout3fiddy

  committed
  b3565b2

  Copy full SHA for b3565b2

• fix: remove double fees accounting in views contract; remove division by zero due to pricision issues in views method; update inflation params if is_killed is set to True

  bout3fiddy

  committed
  f9f7e0f

  Copy full SHA for f9f7e0f

• update inflation params if is_killed is set to True

  bout3fiddy

  committed
  9fad8da

  Copy full SHA for 9fad8da

Commits on Oct 2, 2023

• fix: expose rebasing impl boolean

  bout3fiddy

  committed
  df4aae3

  Copy full SHA for df4aae3

• make stored_rates return dynarray; use that in views; fix tests

  bout3fiddy

  committed
  d9f1b2c

  Copy full SHA for d9f1b2c

• fix: reduce bytecode and remove asset_type

  bout3fiddy

  committed
  7b408a5

  Copy full SHA for 7b408a5

• remove unneeded rate oracle view method to save bytecode

  bout3fiddy

  committed
  145b390

  Copy full SHA for 145b390

Commits on Oct 3, 2023

• chainsec comment: upkeep D oracle on remove_liquidity

  bout3fiddy

  committed
  f61003f

  Copy full SHA for f61003f

• fix: use correct last times in view methods

  bout3fiddy

  committed
  72699ee

  Copy full SHA for 72699ee

• fix: comment

  bout3fiddy

  committed
  6e64610

  Copy full SHA for 6e64610

• add D oracle upkeeping in remove_liquidity for metapools

  bout3fiddy

  committed
  50c0d65

  Copy full SHA for 50c0d65

Commits on Oct 4, 2023

• final auditor comments

  bout3fiddy

  committed
  919f1d0

  Copy full SHA for 919f1d0

• update to vypers 0.3.10rc6. final candidate: 0.3.10; all hail king charles

  bout3fiddy

  committed
  72aabcf

  Copy full SHA for 72aabcf

• fix: version pragma

  bout3fiddy

  committed
  7a285fd

  Copy full SHA for 7a285fd

• rename to set because apply is commit->apply, whereas here we're setting it in one tx

  bout3fiddy

  committed
  7b766a3

  Copy full SHA for 7b766a3

Commits on Oct 5, 2023

• update vyper to 0.3.10 !

  bout3fiddy

  committed
  6d313ee

  Copy full SHA for 6d313ee

• bump gauge version

  bout3fiddy

  committed
  bff1522

  Copy full SHA for bff1522

Commits on Oct 11, 2023

• add erc4626 token support in asset_type = 3

  bout3fiddy

  committed
  237828d

  Copy full SHA for 237828d

Commits on Oct 12, 2023

• add asset types; fix: _stored_rates in plain pools not reading external rates

  bout3fiddy

  committed
  63b46dc

  Copy full SHA for 63b46dc

• use correct asset precisions for erc4626

  bout3fiddy

  committed
  fa9731a

  Copy full SHA for fa9731a

• add tests for erc4626 tokens

  bout3fiddy

  committed
  d23f6e0

  Copy full SHA for d23f6e0

• add helper method to donate amount to vault

  bout3fiddy

  committed
  3f0cd36

  Copy full SHA for 3f0cd36

• fix: remove deprecated var

  bout3fiddy

  committed
  ffe12f0

  Copy full SHA for ffe12f0

• add helper fn for minting tokens

  bout3fiddy

  committed
  b5a073c

  Copy full SHA for b5a073c

Commits on Oct 13, 2023

• add feedback from Ivan

  bout3fiddy

  committed
  b4da1e9

  Copy full SHA for b4da1e9

• separate base pool setup from deploying infra

  bout3fiddy

  committed
  a13a8b8

  Copy full SHA for a13a8b8

Commits on Oct 16, 2023

• add sepolia deployment and boa deployment scripts

  bout3fiddy

  committed
  5fc9b09

  Copy full SHA for 5fc9b09

Commits on Oct 17, 2023

• add gnosis deployment

  bout3fiddy

  committed
  c3bd2c6

  Copy full SHA for c3bd2c6

• fix: doubly adding asset types in add_base_pool

  bout3fiddy

  committed
  af7685d

  Copy full SHA for af7685d

• attempt contract verification

  bout3fiddy

  committed
  c3a25b1

  Copy full SHA for c3a25b1

• remove breakpoint()

  bout3fiddy

  committed
  c86f511

  Copy full SHA for c86f511

• finish gnosis deployment testing

  bout3fiddy

  committed
  fb09ee3

  Copy full SHA for fb09ee3

Commits on Oct 19, 2023

• remove exchange_underlying_received since bytecode length cannot fit in paris evm-version

  bout3fiddy

  committed
  cda42d8

  Copy full SHA for cda42d8

Commits on Oct 20, 2023

• add optimism deployment

  bout3fiddy

  committed
  4aa954c

  Copy full SHA for 4aa954c

• polygon deployment!

  bout3fiddy

  committed
  8b76e57

  Copy full SHA for 8b76e57

• add deployment addresses for polygon

  bout3fiddy

  committed
  7a9a26c

  Copy full SHA for 7a9a26c

• base deployment

  bout3fiddy

  committed
  d564a9f

  Copy full SHA for d564a9f

Commits on Oct 23, 2023

• another round of deployments

  bout3fiddy

  committed
  5926e9b

  Copy full SHA for 5926e9b

Commits on Oct 24, 2023

• more deployments

  bout3fiddy

  committed
  4a52715

  Copy full SHA for 4a52715

• awaiting boa static fee integration

  bout3fiddy

  committed
  eb1b641

  Copy full SHA for eb1b641

Commits on Oct 25, 2023

• add kava deployment

  bout3fiddy

  committed
  01f5bbc

  Copy full SHA for 01f5bbc

• deployed on aurora

  bout3fiddy

  committed
  23bb583

  Copy full SHA for 23bb583

• deployed: polygon zkevm, scroll, ethereum!

  bout3fiddy

  committed
  2eeb0d4

  Copy full SHA for 2eeb0d4

Commits on Oct 26, 2023

• add base pools to factory

  bout3fiddy

  committed
  fd22952

  Copy full SHA for fd22952

Commits on Nov 1, 2023

• add boa scripts and remove ape script

  bout3fiddy

  committed
  61f497f

  Copy full SHA for 61f497f

• park workflows

  bout3fiddy

  committed
  d82428f

  Copy full SHA for d82428f

• fix readme

  bout3fiddy

  committed
  183c16e

  Copy full SHA for 183c16e