-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make sure the tests can be ran easily. This is the first of a list of change aiming at improving the test setup. We will try to keep the changes simple and iterate rather than making a giant pull request that would be painful to be reviewed and merged. Note that the `rpcUrls.test.js` file was added back to tracking and leverages `process.env`. Alternatively we could add dotenv as a dev dependency and use (untracked) `.env` files for RPC URLs. A lot of tests are still failing but at least some pass. Fixing tests will be addressed in follow up pull requests. Tested with both Hardhat and Anvil exporting `ETH_RPC` as: ``` export ETH_RPC=http://127.0.0.1:8545 ``` In follow up pull requests we want to: - fix or skip broken tests - run tests from the CI
- Loading branch information
1 parent
79fe005
commit a60fd64
Showing
6 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,3 @@ package-lock.json | |
pnpm-lock.yaml | ||
yarn.lock | ||
test/temp.test.ts | ||
test/rpcUrls.test.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2462,3 +2462,9 @@ import curve from "@curvefi/api"; | |
// ] | ||
})() | ||
``` | ||
## Tests | ||
```sh | ||
npm run test | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export const { ETH_RPC } = process.env; |