Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port attributes #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Port attributes #486

wants to merge 1 commit into from

Conversation

UnsignedByte
Copy link
Collaborator

Adds port attributes of the form

#[attrib]
port: ['G, 'G+1] 32,
...

Also can technically be used within bundle definitions like

bundle #[attrib] bun[3]: for<i> ['G + i, 'G+i+1] 32;

@UnsignedByte
Copy link
Collaborator Author

I should add a test case for this but right now there are no implemented attributes...

@UnsignedByte
Copy link
Collaborator Author

@rachitnigam if there are no problems here I will merge this and start using it in the scheduling pass. My one question remaining is whether it is a good idea to store an Attributes in every port, considering we are trying to lower the size of the actual control elements. ALternatively we would have to create an IndexStore but I am not sure how reasonable that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachitnigam rachitnigam Awaiting requested review from rachitnigam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UnsignedByte