-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to JS library #509
Open
droberts-ctrlo
wants to merge
36
commits into
ctrlo:dev
Choose a base branch
from
droberts-ctrlo:js-fixes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded basic packages in `package.json` to latest version where possible - Updated `webpack.config.js` to use latest versions of plugins and builders - Updated `tsconfig.json` and `jest.config.js` to enable more consistent imports - Updated JS, TS, and TSX files with the above changes - Removed stale ESLint directives - Updated configurations, and code to ensure tests now pass where they were failing due to breaking changes to libraries - Updated configurations, and code to allow Webpack build to succeed
Also modified code to ensure that build is successful
If it ain't broke!
I will be using this to create a more concise set of commits |
This will take too long - for now I shall run with this commit as it stands I will work with this commit as the base for chart updates |
Draft
Unknown as to why unit tests are failing - they pass locally with no issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable are: