-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed DL3 creation complaining about mismatch in binning. #273
Conversation
It sometimes happened that the IRF files have different bin ranges saved despite using the same input card. The difference is very small, comparable to the numerical accuracy of double precision. I saw it in the files processed in CNAF and my suspicion is that it comes from inhomogenuity of machines over which the code was run. Now if different binning is detected, it checks also if the relative difference exceeds somewhere 10^-15 and only then raises an error.
also set the default language version of python because otherwise pre-commit complained trying to find python 3.1 (??)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 77.27% 77.18% -0.09%
==========================================
Files 22 22
Lines 2618 2621 +3
==========================================
Hits 2023 2023
- Misses 595 598 +3 ☔ View full report in Codecov by Sentry. |
Seems fine to me. Why the changes in pre-commit config? |
pre-commit was failing when I was trying to commit the change to github. For some reason it was trying to use python3.1, no idea why. This solved the problem (and allowed me to commit the changes) and I think it is harmless because we also require python 3.11 in the environment. But I am open to other solutions as well. |
I was just curious (there were no failings in the other PRs, and you just added an if/else, so this is quite strange). BTW, if it works, it is fine |
It sometimes happened that the IRF files have different bin ranges saved despite using the same input card. The difference is very small, comparable to the numerical accuracy of double precision. I saw it in the files processed in CNAF and my suspicion is that it comes from inhomogenuity of machines over which the code was run. Now if different binning is detected, it checks also if the relative difference exceeds somewhere 10^-15 and only then raises an error.