-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coincidence method for the MAGIC broken timestamp data #231
Open
Ryo-Imazawa
wants to merge
33
commits into
cta-observatory:master
Choose a base branch
from
Ryo-Imazawa:dev-ryo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7675799
Added find_offset function
Ryo-Imazawa 2445ccc
Added find_offset module
Ryo-Imazawa 3af3220
Added -t --input-dir_toff option to load the time offset
Ryo-Imazawa c3c7474
The script for obtain the time offset
Ryo-Imazawa f2596b4
minor change
Ryo-Imazawa 94d7b19
Added the explanation and usage
Ryo-Imazawa 4cd38a3
minor changes
Ryo-Imazawa 651b772
This script make coincidence dl1 for each subrun.
Ryo-Imazawa 4043cfb
fixed the typo
Ryo-Imazawa 82f2b24
Delete magicctapipe/scripts/lst1_magic/launch_coincidence_for_brokenG…
Ryo-Imazawa 3e0fd76
Delete magicctapipe/scripts/lst1_magic/lst1_magic_find_time_offset.py
Ryo-Imazawa 4787d99
Create coincident_brokenGPS.py
Ryo-Imazawa 528631e
Changed the output file name
Ryo-Imazawa 4566623
Added the explanation for the Parameters/Returns
Ryo-Imazawa 754badf
minor format change
Ryo-Imazawa d286eab
Minor format change
Ryo-Imazawa 5b3c6eb
Minor format change
Ryo-Imazawa 7837632
modified the bug in coincidence
Ryo-Imazawa 1695783
modified bug of t_magic_all
Ryo-Imazawa cb4ccb9
modified the bug
Ryo-Imazawa 2d06605
modified the scripts
Ryo-Imazawa b4d911e
modified error
Ryo-Imazawa eb53697
modified the logging error
Ryo-Imazawa 8e168fc
modified some statement in coincidence_brokenGPS
Ryo-Imazawa 2a1eae4
modified some bugs
Ryo-Imazawa d49ff0c
Fixed so that it can be applied to files with the name dl1_MAGIC.RunX…
Ryo-Imazawa 0ad568b
fixed the conflicts of the branch
Ryo-Imazawa 271e258
modified the conflict
Ryo-Imazawa ce742a1
fixed the conflict
Ryo-Imazawa fa09a4e
fixed the conflict
Ryo-Imazawa 63c1464
fixed conflict
Ryo-Imazawa 392cefe
fixed conflict
Ryo-Imazawa 5ac261f
fixed the conflict
Ryo-Imazawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what you do in each step is very similar to what you do at the beginning of the function with initial_time_offset None, maybe you can extract this into a separate function, or do the first case as 1 iteration case of multiple iterations?